fix(docs): update cookie consent ui changes #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b82cdc The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
realdreamer
force-pushed
the
fix/update-cookie-consent
branch
from
c186ab2 to
4b899a9
Compare
| @@ -73,13 +73,7 @@ export const menuInLayoutVariants = styleVariants({ | |||
| }); | |||
|
|
|||
| export const menuLayoutVariants = styleVariants({ | |||
| landing: { | |||
There was a problem hiding this comment.
the menu now moves below the consent notification. is this what we want?
There was a problem hiding this comment.
If we're making the notification fixed and other content to be go below this then it makes sense to move the side bar menu as well.
packages/apps/docs/src/components/Layout/components/TitleHeader/style.css.ts
Outdated
Show resolved
Hide resolved
realdreamer
force-pushed
the
fix/update-cookie-consent
branch
from
293bfa3 to
3abe848
Compare
sstraatemans
approved these changes
Oct 11, 2023
eileenmguo
pushed a commit
that referenced
this pull request
Oct 12, 2023
* fix(docs): update cookie consent ui changes * fix(docs): move zIndex value away from sprinkles * fix(docs): make cookie consent sticky * fix(docs): move title header outside of the main content area * fix(docs): tile header global variables * fix(react-ui): move padding to notification content wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.