feat(@kadena/ui): Add responsiveStyle and mapToProperty utility theme functions #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aae4059 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
timoheddes
approved these changes
Oct 10, 2023
sstraatemans
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the grid component, I looked into how the vanilla-extract/css styles and found these utilities that I think can be useful for our codebase as well. I've added them and used them within some of our components and also applied them in the docs site in this PR. Curious to hear what you think!
responsiveStyle - This function takes a responsive object similar to sprinkles, but it allows users to group styles for a specific breakpoint together. It is just a utility for styling breakpoints, but I think it makes the code cleaner and more clear. Note that this will not work for sprinkles, only normal styles
mapToProperty - This function maps a value to a property, but also allows the user to specify a breakpoint. This can be helpful when making certain variants like in the grid component
If approved, I will apply this to the tools site as well