Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/module explorer redesign pt. II #1023

Merged
merged 23 commits into from
Oct 13, 2023
Merged

Feat/module explorer redesign pt. II #1023

merged 23 commits into from
Oct 13, 2023

Conversation

sanderlooijenga
Copy link
Contributor

@sanderlooijenga sanderlooijenga commented Oct 10, 2023 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 28e5a4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 8:20am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
alpha-docs ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 8:20am
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 8:20am
immutable-records ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 8:20am
react-ui ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 8:20am

Sander Looijenga added 21 commits October 11, 2023 11:21
Initial outline implementation
be0bf82
Improve Outline styling a bit
9a424f0
Extract types to separate file
5e03c3a
Use type from new location
b82d2cd
Add onModuleExpand prop to sidepanel + use new types
5af366d
Add hash to tree item
71dc7bf
Add onInterfaceClick prop to Outline + use new type
0fda8c6
Support/forward newly added props + use new type
7026dec
Support/forward newly added props + use new type again
4aca10a
Add hash to property to getModulesMap function
24fc1e5
Use cached data as fallback
2f785d9
Use new location of type + hash property support
52a06c8
Implement new props
3117ae6
Enrich old data with new data (hash) and rerender
804bc36
Truncate the hash
78f430d
Only match active queries, otherwise weird results occur
b4bdfe5
Add a somewhat more descriptive placeholder
1569412
Some minor improvements
22a2761
Make sure capitalization doesn't matter when searching
eb02d08
Add some missing translations
df34181
Add missing namespace to useTranslation hook
a6ba358
@sanderlooijenga sanderlooijenga force-pushed the feat/module-explorer-redesign branch from 66c10ff to a6ba358 Compare October 11, 2023 09:21
@sanderlooijenga sanderlooijenga marked this pull request as ready for review October 11, 2023 10:29
@sanderlooijenga sanderlooijenga merged commit 6701804 into main Oct 13, 2023
3 of 4 checks passed
@sanderlooijenga sanderlooijenga deleted the feat/module-explorer-redesign branch October 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristinaSpasevska KristinaSpasevska KristinaSpasevska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderlooijenga @KristinaSpasevska