Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@kadena/react-ui): Updated ProfileCard component #1032

Merged
merged 1 commit into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/hungry-files-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@kadena/react-ui': minor
---

Renamed the ProfileCard component to ProfileSummary and refactored it to use a
subcomponent structure

This file was deleted.

71 changes: 0 additions & 71 deletions packages/libs/react-ui/src/components/ProfileCard/ProfileCard.tsx

This file was deleted.

4 changes: 0 additions & 4 deletions packages/libs/react-ui/src/components/ProfileCard/index.ts

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,29 +1,20 @@
import { sprinkles } from '@theme/sprinkles.css';
import { style } from '@vanilla-extract/css';

export const imageContainerClass = style([
sprinkles({
borderRadius: '$round',
overflow: 'hidden',
width: '100%',
}),
]);

export const imageClass = style([
sprinkles({
width: '100%',
height: '100%',
borderRadius: '$round',
}),
{
width: '$24',
height: '$24',
objectFit: 'cover',
},
}),
]);

export const boldTextClass = style([
sprinkles({
marginY: '$2',
fontWeight: '$bold',
display: 'block',
}),
]);

Expand All @@ -42,10 +33,8 @@ export const tagContainerClass = style([
ulClass,
sprinkles({
flexDirection: 'row',
}),
{
listStyleType: 'none',
},
}),
]);

export const linkContainerClass = style([
Expand All @@ -54,7 +43,6 @@ export const linkContainerClass = style([
flexDirection: 'column',
marginLeft: '$4',
}),
{},
]);

export const tagClass = style([
Expand All @@ -63,8 +51,11 @@ export const tagClass = style([
}),
]);

export const profileCardClass = style([
export const containerClass = style([
sprinkles({
color: '$foreground',
display: 'flex',
flexDirection: 'row',
gap: '$6',
}),
]);
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import type { IProfileSummaryRootProps } from '@components/ProfileSummary';
import { ProfileSummary } from '@components/ProfileSummary';
import type { Meta, StoryObj } from '@storybook/react';
import React from 'react';

type StoryComponentType = IProfileSummaryRootProps & {
links: Record<string, string>;
};

const meta: Meta<StoryComponentType> = {
title: 'Content/ProfileSummary',
component: ProfileSummary.Root,
parameters: {
docs: {
description: {
component:
'The ProfileSummary component renders a card with a profile picture, name, title, tags, and links. The links are rendered using the `Link` component and can be set with the `links` prop.',
},
},
},
};

export default meta;

type Story = StoryObj<StoryComponentType>;

export const Primary: Story = {
name: 'ProfileSummary',
args: {
name: 'Tasos Bitsios',
title: 'Developer Experience Developer (DED)',
tags: ['Chainweb-stream', 'SSE'],
imageSrc: 'https://avatars.githubusercontent.com/u/115649719?v=4',
links: {
'Personal website': 'https://tasosbitsios.com',
Twitter: 'https://twitter.com/tasosbitsios',
'Custom link': 'https://kadena.io',
},
},
render: ({ name, title, tags, imageSrc, links }) => {
return (
<ProfileSummary.Root
name={name}
title={title}
tags={tags}
imageSrc={imageSrc}
>
{Object.entries(links).map(([label, href]) => (
<ProfileSummary.Link href={href as string} key={href as string}>
{label}
</ProfileSummary.Link>
))}
</ProfileSummary.Root>
);
},
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import type { ILinkProps } from '@components/Link';
import { Link } from '@components/Link';
import type { FC } from 'react';
import React from 'react';

export interface IProfileSummaryLinkProps extends ILinkProps {}

export const ProfileSummaryLink: FC<IProfileSummaryLinkProps> = ({
children,
...restLinkProps
}) => {
return (
<li>
<Link {...restLinkProps}>{children}</Link>
</li>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import {
boldTextClass,
containerClass,
imageClass,
linkContainerClass,
tagClass,
tagContainerClass,
} from './ProfileSummary.css';
import type { IProfileSummaryLinkProps } from './ProfileSummaryLink';

import { Tag } from '@components/Tag';
import type { FC, FunctionComponentElement } from 'react';
import React from 'react';

export interface IProfileSummaryRootProps {
name: string;
title: string;
imageSrc: string;
tags?: string[];
children: FunctionComponentElement<IProfileSummaryLinkProps>[];
}

export const ProfileSummaryRoot: FC<IProfileSummaryRootProps> = ({
name,
title,
imageSrc,
tags = undefined,
children,
}) => {
return (
<div className={containerClass}>
<img className={imageClass} src={imageSrc} alt={name} />
<div>
<span className={boldTextClass}>{name}</span>
<span>{title}</span>

{tags && (
<ul className={tagContainerClass}>
{tags.map((tag, i) => (
<li className={tagClass} key={i}>
<Tag key={i}>{tag}</Tag>
</li>
))}
</ul>
)}

{children && (
<>
<span className={boldTextClass}>Links</span>
<ul className={linkContainerClass}>{children}</ul>
</>
)}
</div>
</div>
);
};
18 changes: 18 additions & 0 deletions packages/libs/react-ui/src/components/ProfileSummary/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import type { IProfileSummaryLinkProps } from './ProfileSummaryLink';
import { ProfileSummaryLink } from './ProfileSummaryLink';
import type { IProfileSummaryRootProps } from './ProfileSummaryRoot';
import { ProfileSummaryRoot } from './ProfileSummaryRoot';

import type { FC } from 'react';

export { IProfileSummaryLinkProps, IProfileSummaryRootProps };

interface IProfileSummaryProps {
Root: FC<IProfileSummaryRootProps>;
Link: FC<IProfileSummaryLinkProps>;
}

export const ProfileSummary: IProfileSummaryProps = {
Root: ProfileSummaryRoot,
Link: ProfileSummaryLink,
};
7 changes: 5 additions & 2 deletions packages/libs/react-ui/src/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ export type {
IGradientTextProps,
ILabelProps,
} from './Typography';
export type { IProfileCardProps } from './ProfileCard';
export type {
IProfileSummaryRootProps,
IProfileSummaryLinkProps,
} from './ProfileSummary';

export { Accordion } from './Accordion';
export { Box } from './Box';
Expand Down Expand Up @@ -85,4 +88,4 @@ export { Tooltip } from './Tooltip';
export { TrackerCard } from './TrackerCard/TrackerCard';
export { Tree } from './Tree';
export { Divider } from './Divider/Divider';
export { ProfileCard } from './ProfileCard';
export { ProfileSummary } from './ProfileSummary';
Loading