Refactor/rename input wrapper #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferreroltd
requested review from
eileenmguo,
sstraatemans,
salamaashoush,
sanderlooijenga,
KristinaSpasevska,
alber70g,
MRVDH and
nil-amrutlal
as code owners
🦋 Changeset detectedLatest commit: df48185 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
ferreroltd
commented
Nov 8, 2023
packages/libs/react-ui/src/components/Form/FormFieldWrapper/FormFieldWrapper.css.ts
Outdated
Show resolved
Hide resolved
ferreroltd
commented
Nov 8, 2023
packages/libs/react-ui/src/components/Form/FormFieldWrapper/FormFieldWrapper.tsx
Outdated
Show resolved
Hide resolved
eileenmguo
reviewed
Nov 8, 2023
packages/libs/react-ui/src/components/Form/FormFieldWrapper/FormFieldWrapper.tsx
Outdated
Show resolved
Hide resolved
sanderlooijenga
approved these changes
Nov 8, 2023
isaozler
approved these changes
Nov 9, 2023
MRVDH
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is renaming the InputWrapper to FieldWrapper ans applying some spacing in the case that it contains multiple elements. This spacing is also needed due to the styles for focus and states that the inputs may have.
OLD:
NEW:
With focus style: