React UI: Navigation Header Accordion component #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bbfea2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
2ae3516 to
0d804f0
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
9c70417 to
3273290
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
a15f04b to
2a4131c
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
cb84d06 to
df52caa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
b13afd5 to
9098c9c
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
9098c9c to
a44b565
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
08f7787 to
8ca3927
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
1255d77 to
ade31a9
Compare
timoheddes
force-pushed
the
feat/nav-accordion
branch
from
d64c803 to
a1312dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the NavAccordion component as a variant of the Accordion component, using similar structure and logic. Both components have been refactored and are using context to manage state and pass down props to their subcomponents.
Asana task
The component consists of four sub components:
<NavAccordion.Root> as the parent container
<NavAccordion.Section> for each navigational section (collapsable)
<NavAccordion.Group> to create sub sections (lists) that group related navigational links (collapsable)
<NavAccordion.Link> to create links that can be used to navigate (using our Link component and supporting the
asChildprop)Design and colours have been discussed with and checked by Isa.