Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First setup for Tools E2E tests #996
First setup for Tools E2E tests #996
Changes from 67 commits
631543e
1e92585
886a111
8519f6c
0209111
0795c5e
23cc770
b5736d8
e9071e2
9001abb
015c7e5
f0e436c
f460159
33d7c10
fe13290
c318f18
91b8e03
5774805
70e3a94
835f1b9
b863933
8139cf3
0f4a8d7
6888342
5fe9b7e
088a1f1
d946d9f
b7bef21
5c2873e
eab972e
5b6447a
39fbf2c
3cb4023
2fb3628
172b14e
411f0ae
cc8ede2
83647c0
428b782
7623748
891e34a
3460c2c
c61e87d
84e983c
ff50e8c
f6f44fd
0d4a3ca
6cb0822
569620e
3c87ac0
5e1ab63
2397603
5b502bf
af652ae
992b1c3
b62db37
dff0379
4f52f22
c6fa612
30f9585
8d7b385
bf96d7e
4cfc403
21ae5b2
7f65267
2d53b8e
976d2c5
6858376
f095214
ac99ec0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This +
pnpm format:md
is a start (not necessarily in this PR)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can omit
npx
, it should be available as a binary in$PATH
. Package managers addnode_modules/.bin
to$PATH
automatically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can omit
npx
, it should be available as a binary in$PATH
. Package managers addnode_modules/.bin
to$PATH
automatically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, can be without backticks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when this is an empty string? For clarity could be
process.env.CI === undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty string assume false, but i'll change it either way to make it more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might not be good/specific enough, but
object
is usually too loose. Oh well, this is just a mock. And then we are forced to type stuff when declaring vars, lol. This can be turned off in ESLint settings (maybe just override for mock folders). Less work to just import the actual type if we have it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These objects are representations of the response objects made by the blockchain. I'm not entirely sure we can make these types much more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use named exports, for easy importing and maintainability