1040 prototype email gateway #1048
Conversation
…registration email using a very draft version of the email template
…rst registered. Simplified gateway configuration structures. Added dummy email sender (to debug templating mostly).
…d in predefined config
…ing to configuration
…lier created (so that we swallow new emails from config!)
|
|
||
| let account_repo = from_catalog_n!(ctx, dyn AccountRepository); | ||
| match account_repo | ||
| .update_account_email(&self.account.id, new_email.clone()) |
There was a problem hiding this comment.
Shouldn't this go through a use case and do auth before changing email? Currently it looks like this will allow anyone (including anonymous users) to change any other account's email.
| odf = { workspace = true } | ||
| time-source = { workspace = true } | ||
|
|
||
| askama = { version = "0.12" } |
There was a problem hiding this comment.
Hm, I expected to see this dependency in an infra layer, not in a domain crate
| @@ -23,12 +23,15 @@ doctest = false | |||
|
|
|||
| [dependencies] | |||
| database-common = { workspace = true } | |||
| email-gateway = { workspace = true } | |||
There was a problem hiding this comment.
This seems like an odd coupling. I expected that in account domain layer we only emit messages about account life cycle and react to them elsewhere.
The fact that these messages trigger an email notification is IMO neither a account domain concern, nor even an infra-level account service concern. Sending emails notifs is more like Kamu Node-level business logic concern.
I would suggest moving the templating and email sending into a crate in kamu-node. Seems like one of those things that we'll never need on CLI level.
| let rendered_registration_body = registration_email.render().unwrap(); | ||
|
|
||
| self.email_sender | ||
| .send_email( |
There was a problem hiding this comment.
Yea, as per my other comment this looks completely out of place in account domain crate.
Description
Closes: #1040
Integration of email gateway (Postmark):
EmailSendercrate and prototypedPostmark-based implementationaskomatemplating engine and defined base HTML-rich template for all emailsAdded GQL suport to query and update email on the currently logged account.
Emails are mandatory for Kamu accounts now:
Checklist before requesting a review