Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things that you only find during a release #437

Merged

Conversation

Firstyear
Copy link
Member

As is tradition, during a release you find everything that doesn't work like git dependencies, missing versions in the workspace, missing items in Cargo.toml etc. This is a smattering of smaller tidy ups to fix these during the cargo publish process.

  • [ x ] cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to make a "no git/paths in the cargo.toml" check somewhere in the release planning 😄

@Firstyear Firstyear merged commit 628599a into kanidm:master Apr 28, 2024
33 checks passed
@Firstyear Firstyear deleted the 20240428-post-release-missed-things branch April 28, 2024 05:43
@Firstyear
Copy link
Member Author

Probably need to make a "no git/paths in the cargo.toml" check somewhere in the release planning 😄

We hit a lot of problems with libraries not doing releases with features we needed, but I think mostly they are fixed now?

kikuomax pushed a commit to codemonger-io/webauthn-rs that referenced this pull request Nov 24, 2024
Cherry-picking notes:
- Bumps `webauthn-rs-error` → 0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants