Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add navbar and footer #34

Merged
merged 7 commits into from
Oct 10, 2024
Merged

Conversation

magnusgiverin
Copy link
Collaborator

No description provided.

@andreaslhjulstad
Copy link
Collaborator

Would be nice with some E2E tests for the component

@SverreNystad SverreNystad changed the title Feat: Added navbar and footer feat: Add navbar and footer Oct 9, 2024
Copy link
Collaborator

@andreaslhjulstad andreaslhjulstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

There are a couple of small things that need attention.
But overall, great job! 🌟

@magnusgiverin magnusgiverin merged commit f4b963e into main Oct 10, 2024
1 check passed
@magnusgiverin magnusgiverin deleted the feat/create-navbar-for-application branch October 10, 2024 13:49
Copy link
Collaborator

@SverreNystad SverreNystad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a navbar component and place it at the top of all the pages
3 participants