some fix #26
Open
some fix #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cecilwang
commented
Mar 7, 2022
Comment on lines
-19
to
-21
| has_fwd_op = any(op_name in FWD_OPS for op_name in op_names) | ||
| has_bwd_op = any(op_name in BWD_OPS for op_name in op_names) | ||
| has_bwd_op_with_inputs = any(op_name in BWD_OPS_WITH_INPUTS for op_name in op_names) |
There was a problem hiding this comment.
Sometimes, op_names = ['kron'] which is not in FWD_OPS.
We can change FWD_OPS, or check it after parsing 'kron'
There was a problem hiding this comment.
OP_COV_KRON is in FWD_OPS
https://github.com/kazukiosawa/asdfghjkl/blob/0.1/asdfghjkl/operations/operation.py#L34
There was a problem hiding this comment.
They are not the same, sometimes, op_names=[SHAPE_KRON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.