Skip to content

Commit

Permalink
Add webhook timeouts (#731)
Browse files Browse the repository at this point in the history
Signed-off-by: be0x74a <be0x74a@gmail.com>
  • Loading branch information
be0x74a authored Jan 24, 2025
1 parent 33070ca commit 213d205
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 3 additions & 3 deletions keda/templates/webhooks/validatingconfiguration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ webhooks:
resources:
- scaledobjects
sideEffects: None
timeoutSeconds: 10
timeoutSeconds: {{ .Values.webhooks.timeoutSeconds | default 10 }}
- admissionReviewVersions:
- v1
clientConfig:
Expand All @@ -67,7 +67,7 @@ webhooks:
resources:
- triggerauthentications
sideEffects: None
timeoutSeconds: 10
timeoutSeconds: {{ .Values.webhooks.timeoutSeconds | default 10 }}
- admissionReviewVersions:
- v1
clientConfig:
Expand All @@ -91,5 +91,5 @@ webhooks:
resources:
- clustertriggerauthentications
sideEffects: None
timeoutSeconds: 10
timeoutSeconds: {{ .Values.webhooks.timeoutSeconds | default 10 }}
{{- end }}
2 changes: 2 additions & 0 deletions keda/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ webhooks:
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
# -- Timeout in seconds for KEDA admission webhooks
timeoutSeconds: 10
# -- Enable webhook to use host network, this is required on EKS with custom CNI
useHostNetwork: false
# -- Name of the KEDA admission webhooks
Expand Down

0 comments on commit 213d205

Please sign in to comment.