Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support disabling docker legacy service links creation in keda containers #725

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Dec 31, 2024

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

@mindw mindw requested a review from a team as a code owner December 31, 2024 09:09
@mindw mindw changed the title Disable docker legacy service links feat: disable docker legacy service links creation in keda containers Dec 31, 2024
@JorTurFer
Copy link
Member

Currently, the value as default is 'true' or false? I mean, when the property isn't set

@mindw
Copy link
Contributor Author

mindw commented Jan 23, 2025

Default is true.

keda/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>
@mindw mindw force-pushed the mindw/disable_service_links branch 2 times, most recently from 1ac0c3a to 94c86a9 Compare January 25, 2025 06:26
Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>
@mindw mindw force-pushed the mindw/disable_service_links branch from 94c86a9 to 686ba5d Compare January 25, 2025 06:28
@mindw mindw changed the title feat: disable docker legacy service links creation in keda containers feat: support disabling docker legacy service links creation in keda containers Jan 25, 2025
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks for the improvement

@JorTurFer JorTurFer merged commit 4092615 into kedacore:main Jan 26, 2025
36 checks passed
@mindw mindw deleted the mindw/disable_service_links branch January 27, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants