Modifications to Redetect Fields #2422
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
commented
Dec 24, 2024
| @@ -125,7 +125,8 @@ const sendMessageToTab = async function(message) { | |||
| } | |||
|
|
|||
| statusResponse(await browser.runtime.sendMessage({ | |||
| action: 'get_status' | |||
| action: 'get_status', | |||
| args: [ true ] | |||
There was a problem hiding this comment.
This boolean changes the request to an internal call without sending messages to KeePassXC.
|
What if the login dialog is in an iframe with a different url and I need to set the username only detection? |
It's valid concern that I also thought about. I need to find a site where I can test this. EDIT: Found one. Gonna postpone this fix to a later release. Needs some adjustments. Even the version before this PR does not work good enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the
get_statusrequest after Redetect Fields was not an internal call, but it requested status from KeePassXC that is not even needed here. It is enough to update thepagevariables and refresh the popup with new data directly.Other improvements:
pagewith proper functions.false.Testing strategy
Manually. For example Patreon's login page can be used when Predefined Sites is disabled in the extension settings.
Type of change