Merge pull request #21 from kellerkinderDE/feature/KLARNASUPPORT-551

[KLARNASUPPORT-551] Fix compatibility to PHP 8.0
kellerkinderDE · Apr 5, 2022 · 43cdeed · 43cdeed
2 parents 132542a + 9a86daa
commit 43cdeed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 ### Fixed
 - Fixed a missing auth header during customer token generation
 - Fixed the config reader to return the correct value when falsy values are configured (e.g. 0, 'false')
+- Fixed compatibility to PHP 8.0
 ### Added
 - Allowed manual and individual adding of positions which are not related to an article
 

diff --git a/src/Components/Transformer/LineItemTransformer.php b/src/Components/Transformer/LineItemTransformer.php
@@ -292,10 +292,14 @@ public function createShippingLineItem($shippingCostsWithTax, $shippingCostsNet,
      */
     public function getUnitPriceWithTax(array $lineItem): float
     {
-        $netPriceIsShown = isset($lineItem['amountWithTax']) ? true : false;
+        $netPrice = $lineItem['amountWithTax'] ?? null;
 
-        if ($netPriceIsShown) {
-            return round(str_replace(',', '.', $lineItem['amountWithTax']) / $lineItem['quantity'], 2);
+        if ($netPrice !== null) {
+            if (is_string($netPrice)) {
+                $netPrice = (float) str_replace(',', '.', $lineItem['amountWithTax']);
+            }
+
+            return round($netPrice / $lineItem['quantity'], 2);
         }
 
         return (float) $lineItem['priceNumeric'];