Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements-jax-cuda.txt for clarity and compatibility #20730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saiabhinav001
Copy link

This PR updates the requirements-jax-cuda.txt file to improve clarity, maintain compatibility, and align with best practices for dependency management.

Changes

  • Added inline comments to explain each dependency and its purpose.
  • Verified compatibility of TensorFlow, PyTorch, and JAX dependencies with their respective requirements.
  • Ensured pinned versions (e.g., jax[cuda12]==0.4.28) remain stable for CI pipelines.

Please review and let me know if further changes are required.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.83%. Comparing base (881d8da) to head (f606057).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20730   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         552      552           
  Lines       51363    51363           
  Branches     7944     7944           
=======================================
  Hits        42034    42034           
  Misses       7375     7375           
  Partials     1954     1954           
Flag Coverage Δ
keras 81.65% <ø> (ø)
keras-jax 63.95% <ø> (ø)
keras-numpy 58.81% <ø> (ø)
keras-openvino 29.84% <ø> (ø)
keras-tensorflow 64.62% <ø> (ø)
keras-torch 63.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

torchvision>=0.16.0
torch-xla
torch-xla # Typically for TPU; no conflict with CPU builds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is for savedmodel export? not sure actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants