jobs/rootfs-trigger: pass KCI_CORE_[URL|BRANCH] #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Untested, but should address: #29 |
|
Please add a message in the commit explaining why this is needed. |
The trigger job should pass KCI_CORE_[URL|BRANCH] to the build job to be sure that both trigger and build are using the same source. Without this, modifying the URL/branch in the trigger job has no effect on the build job. Signed-off-by: Kevin Hilman <khilman@baylibre.com>
khilman
force-pushed
the
dev/rootfs-trigger-params
branch
from
f212534 to
3ff85a6
Compare
|
Updated with description in commit log. |
|
OK thanks - this will matter when we start using settings files, as we could keep the parameters to override things on a per-build basis. |
Lakshmipathi
approved these changes
Aug 18, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Hilman khilman@baylibre.com