Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call urlparse less frequently #609

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

mbrunthaler
Copy link
Contributor

Currently, urlparse is invoked for all properties of uri in vcr.request.Request which has an impact on performance especially with lengthy cassettes. I've changed this to use a property such that urlparse is only invoked when uri is changed.

@mbrunthaler mbrunthaler changed the title Call urllib.parse less frequently Call urlparse less frequently Sep 30, 2021
@kevin1024 kevin1024 force-pushed the master branch 3 times, most recently from df3997c to 34d5384 Compare June 26, 2023 17:54
@jairhenrique jairhenrique reopened this Jan 4, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (c3767c2) to head (00f2982).
Report is 282 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   89.85%   92.29%   +2.44%     
==========================================
  Files          27       27              
  Lines        1734     1844     +110     
  Branches      285      245      -40     
==========================================
+ Hits         1558     1702     +144     
+ Misses        140       95      -45     
- Partials       36       47      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jairhenrique jairhenrique merged commit ac230b7 into kevin1024:master Jan 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants