refactor: Use new collection initializers (#292)

* refactor(): Use collection initializers

* version bump stylecop to 1.2.0-beta.556

src/API/CompanyName.MyMeetings.API/Configuration/Authorization/AuthorizationChecker.cs

@@ -11,7 +11,7 @@ public static void CheckAllEndpoints()
             var assembly = typeof(Startup).Assembly;
             var allControllerTypes = assembly.GetTypes().Where(x => x.IsSubclassOf(typeof(ControllerBase)));
 
-            var notProtectedActionMethods = new List<string>();
+            List<string> notProtectedActionMethods = [];
             foreach (var controllerType in allControllerTypes)
             {
                 var controllerHasPermissionAttribute = controllerType.GetCustomAttribute<HasPermissionAttribute>();

src/BuildingBlocks/Domain/Entity.cs

@@ -20,7 +20,7 @@ public void ClearDomainEvents()
         /// <param name="domainEvent">Domain event.</param>
         protected void AddDomainEvent(IDomainEvent domainEvent)
         {
-            _domainEvents ??= new List<IDomainEvent>();
+            _domainEvents ??= [];
 
             this._domainEvents.Add(domainEvent);
         }

src/BuildingBlocks/Infrastructure/DomainEventsDispatching/DomainEventsDispatcher.cs

@@ -39,7 +39,7 @@ public async Task DispatchEventsAsync()
         {
             var domainEvents = _domainEventsProvider.GetAllDomainEvents();
 
-            var domainEventNotifications = new List<IDomainEventNotification<IDomainEvent>>();
+            List<IDomainEventNotification<IDomainEvent>> domainEventNotifications = [];
             foreach (var domainEvent in domainEvents)
             {
                 Type domainEvenNotificationType = typeof(IDomainEventNotification<>);

src/BuildingBlocks/Infrastructure/EventBus/InMemoryEventBus.cs

@@ -28,7 +28,7 @@ public void Subscribe<T>(IIntegrationEventHandler<T> handler)
                 }
                 else
                 {
-                    _handlersDictionary.Add(eventType, new List<IIntegrationEventHandler> { handler });
+                    _handlersDictionary.Add(eventType, [handler]);
                 }
             }
         }

src/Directory.Packages.props

@@ -1,6 +1,6 @@
 <Project>
   <ItemGroup>
-    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.507" PrivateAssets="All" />
+    <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556" PrivateAssets="All" />
   </ItemGroup>
 
   <ItemGroup Condition="$(MSBuildProjectName.EndsWith('API'))">

src/Modules/Administration/Infrastructure/Configuration/Processing/InternalCommands/InternalCommandsModule.cs

@@ -37,7 +37,7 @@ private void CheckMappings()
                                 x.BaseType == typeof(InternalCommandBase)))
                 .ToList();
 
-            List<Type> notMappedInternalCommands = new List<Type>();
+            List<Type> notMappedInternalCommands = [];
             foreach (var internalCommand in internalCommands)
             {
                 _internalCommandsMap.TryGetBySecond(internalCommand, out var name);

src/Modules/Administration/Infrastructure/Configuration/Processing/Outbox/OutboxModule.cs

@@ -40,7 +40,7 @@ private void CheckMappings()
                 .Where(x => x.GetInterfaces().Contains(typeof(IDomainEventNotification)))
                 .ToList();
 
-            List<Type> notMappedNotifications = new List<Type>();
+            List<Type> notMappedNotifications = [];
             foreach (var domainEventNotification in domainEventNotifications)
             {
                 _domainNotificationsMap.TryGetBySecond(domainEventNotification, out var name);

src/Modules/Administration/Tests/ArchTests/Application/ApplicationTests.cs

@@ -122,7 +122,7 @@ public void InternalCommand_Should_Have_JsonConstructorAttribute()
                 .Inherit(typeof(InternalCommandBase<>))
                 .GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
 
             foreach (var type in types)
             {
@@ -155,7 +155,7 @@ public void MediatR_RequestHandler_Should_NotBe_Used_Directly()
                 .Should().ImplementInterface(typeof(IRequestHandler<>))
                 .GetTypes();
 
-            List<Type> failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in types)
             {
                 bool isCommandHandler = type.GetInterfaces().Any(x =>
@@ -184,7 +184,7 @@ public void Command_With_Result_Should_Not_Return_Unit()
                 .That().ImplementInterface(commandWithResultHandlerType)
                 .GetTypes().ToList();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (Type type in types)
             {
                 Type interfaceType = type.GetInterface(commandWithResultHandlerType.Name);

src/Modules/Administration/Tests/ArchTests/Domain/DomainTests.cs

@@ -45,7 +45,7 @@ public void Entity_Which_Is_Not_Aggregate_Root_Cannot_Have_Public_Members()
                                               BindingFlags.Instance |
                                               BindingFlags.Static;
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in types)
             {
                 var publicFields = type.GetFields(bindingFlags);
@@ -75,7 +75,7 @@ public void Entity_Cannot_Have_Reference_To_Other_AggregateRoot()
                                               BindingFlags.NonPublic |
                                               BindingFlags.Instance;
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in entityTypes)
             {
                 var fields = type.GetFields(bindingFlags);
@@ -112,7 +112,7 @@ public void Entity_Should_Have_Parameterless_Private_Constructor()
                 .That()
                 .Inherit(typeof(Entity)).GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var entityType in entityTypes)
             {
                 bool hasPrivateParameterlessConstructor = false;
@@ -144,7 +144,7 @@ public void Domain_Object_Should_Have_Only_Private_Constructors()
                         .Inherit(typeof(ValueObject))
                 .GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var domainObjectType in domainObjectTypes)
             {
                 var constructors = domainObjectType.GetConstructors(BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance);
@@ -167,7 +167,7 @@ public void ValueObject_Should_Have_Private_Constructor_With_Parameters_For_His_
                 .That()
                 .Inherit(typeof(ValueObject)).GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var entityType in valueObjects)
             {
                 bool hasExpectedConstructor = false;

src/Modules/Administration/Tests/ArchTests/SeedWork/TestBase.cs

@@ -17,7 +17,7 @@ public abstract class TestBase
 
         protected static void AssertAreImmutable(IEnumerable<Type> types)
         {
-            IList<Type> failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in types)
             {
                 if (type.GetFields().Any(x => !x.IsInitOnly) || type.GetProperties().Any(x => x.CanWrite))

src/Modules/Administration/Tests/UnitTests/SeedWork/DomainEventsTestHelper.cs

@@ -8,7 +8,7 @@ public class DomainEventsTestHelper
     {
         public static List<IDomainEvent> GetAllDomainEvents(Entity aggregate)
         {
-            List<IDomainEvent> domainEvents = new List<IDomainEvent>();
+            List<IDomainEvent> domainEvents = [];
 
             if (aggregate.DomainEvents != null)
             {

src/Modules/Meetings/Application/MeetingCommentingConfigurations/DisableMeetingCommentingConfiguration/DisableMeetingCommentingConfigurationCommandHandler.cs

@@ -31,7 +31,7 @@ public async Task Handle(DisableMeetingCommentingConfigurationCommand command, C
             var meetingCommentingConfiguration = await _meetingCommentingConfigurationRepository.GetByMeetingIdAsync(new MeetingId(command.MeetingId));
             if (meetingCommentingConfiguration == null)
             {
-                throw new InvalidCommandException(new List<string> { "Meeting commenting configuration for disabling commenting must exist." });
+                throw new InvalidCommandException(["Meeting commenting configuration for disabling commenting must exist."]);
             }
 
             var meeting = await _meetingRepository.GetByIdAsync(new MeetingId(command.MeetingId));

src/Modules/Meetings/Application/MeetingCommentingConfigurations/EnableMeetingCommentingConfiguration/EnableMeetingCommentingConfigurationCommandHandler.cs

@@ -31,7 +31,7 @@ public async Task Handle(EnableMeetingCommentingConfigurationCommand command, Ca
             var meetingCommentingConfiguration = await _meetingCommentingConfigurationRepository.GetByMeetingIdAsync(new MeetingId(command.MeetingId));
             if (meetingCommentingConfiguration == null)
             {
-                throw new InvalidCommandException(new List<string> { "Meeting commenting configuration for enabling commenting must exist." });
+                throw new InvalidCommandException(["Meeting commenting configuration for enabling commenting must exist."]);
             }
 
             var meeting = await _meetingRepository.GetByIdAsync(new MeetingId(command.MeetingId));

src/Modules/Meetings/Application/MeetingComments/AddMeetingComment/AddMeetingCommentCommandHandler.cs

@@ -35,7 +35,7 @@ public async Task<Guid> Handle(AddMeetingCommentCommand command, CancellationTok
             var meeting = await _meetingRepository.GetByIdAsync(new MeetingId(command.MeetingId));
             if (meeting == null)
             {
-                throw new InvalidCommandException(new List<string> { "Meeting for adding comment must exist." });
+                throw new InvalidCommandException(["Meeting for adding comment must exist."]);
             }
 
             var meetingGroup = await _meetingGroupRepository.GetByIdAsync(meeting.GetMeetingGroupId());

src/Modules/Meetings/Application/MeetingComments/AddMeetingCommentLike/AddMeetingCommentLikeCommandHandler.cs

@@ -32,7 +32,7 @@ public async Task Handle(AddMeetingCommentLikeCommand request, CancellationToken
             var meetingComment = await _meetingCommentRepository.GetByIdAsync(new MeetingCommentId(request.MeetingCommentId));
             if (meetingComment == null)
             {
-                throw new InvalidCommandException(new List<string> { "To add like the comment must exist." });
+                throw new InvalidCommandException(["To add like the comment must exist."]);
             }
 
             var connection = _sqlConnectionFactory.GetOpenConnection();

src/Modules/Meetings/Application/MeetingComments/AddMeetingCommentReply/AddReplyToMeetingCommentCommandHandler.cs

@@ -30,7 +30,7 @@ public async Task<Guid> Handle(AddReplyToMeetingCommentCommand command, Cancella
             var meetingComment = await _meetingCommentRepository.GetByIdAsync(new MeetingCommentId(command.InReplyToCommentId));
             if (meetingComment == null)
             {
-                throw new InvalidCommandException(new List<string> { "To create reply the comment must exist." });
+                throw new InvalidCommandException(["To create reply the comment must exist."]);
             }
 
             var meeting = await _meetingRepository.GetByIdAsync(meetingComment.GetMeetingId());

src/Modules/Meetings/Application/MeetingComments/EditMeetingComment/EditMeetingCommentCommandHandler.cs

@@ -27,7 +27,7 @@ public async Task Handle(EditMeetingCommentCommand command, CancellationToken ca
             var meetingComment = await _meetingCommentRepository.GetByIdAsync(new MeetingCommentId(command.MeetingCommentId));
             if (meetingComment == null)
             {
-                throw new InvalidCommandException(new List<string> { "Meeting comment for editing must exist." });
+                throw new InvalidCommandException(["Meeting comment for editing must exist."]);
             }
 
             var meetingCommentingConfiguration = await _meetingCommentingConfigurationRepository.GetByMeetingIdAsync(meetingComment.GetMeetingId());

src/Modules/Meetings/Application/MeetingComments/RemoveMeetingComment/RemoveMeetingCommentCommandHandler.cs

@@ -27,7 +27,7 @@ public async Task Handle(RemoveMeetingCommentCommand command, CancellationToken
             var meetingComment = await _meetingCommentRepository.GetByIdAsync(new MeetingCommentId(command.MeetingCommentId));
             if (meetingComment == null)
             {
-                throw new InvalidCommandException(new List<string> { "Meeting comment for removing must exist." });
+                throw new InvalidCommandException(["Meeting comment for removing must exist."]);
             }
 
             var meeting = await _meetingRepository.GetByIdAsync(meetingComment.GetMeetingId());

src/Modules/Meetings/Application/MeetingComments/RemoveMeetingCommentLike/RemoveMeetingCommentLikeCommandHandler.cs

@@ -22,7 +22,7 @@ public async Task Handle(RemoveMeetingCommentLikeCommand command, CancellationTo
             var commentLike = await _meetingMemberCommentLikesRepository.GetAsync(_memberContext.MemberId, new MeetingCommentId(command.MeetingCommentId));
             if (commentLike == null)
             {
-                throw new InvalidCommandException(new List<string> { "Meeting comment like for removing must exist." });
+                throw new InvalidCommandException(["Meeting comment like for removing must exist."]);
             }
 
             commentLike.Remove();

src/Modules/Meetings/Domain/MeetingGroups/MeetingGroup.cs

@@ -52,8 +52,7 @@ private MeetingGroup(MeetingGroupProposalId meetingGroupProposalId, string name,
 
             this.AddDomainEvent(new MeetingGroupCreatedDomainEvent(this.Id, creatorId));
 
-            this._members = new List<MeetingGroupMember>();
-            this._members.Add(MeetingGroupMember.CreateNew(this.Id, this._creatorId, MeetingGroupMemberRole.Organizer));
+            this._members = [MeetingGroupMember.CreateNew(this.Id, this._creatorId, MeetingGroupMemberRole.Organizer)];
         }
 
         public void EditGeneralAttributes(string name, string description, MeetingGroupLocation location)

src/Modules/Meetings/Domain/Meetings/Meeting.cs

@@ -11,9 +11,15 @@ namespace CompanyName.MyMeetings.Modules.Meetings.Domain.Meetings
 {
     public class Meeting : Entity, IAggregateRoot
     {
-        public MeetingId Id { get; private set; }
+        private readonly MeetingGroupId _meetingGroupId;
+
+        private readonly List<MeetingAttendee> _attendees;
+
+        private readonly List<MeetingNotAttendee> _notAttendees;
+
+        private readonly List<MeetingWaitlistMember> _waitlistMembers;
 
-        private MeetingGroupId _meetingGroupId;
+        public MeetingId Id { get; private set; }
 
         private string _title;
 
@@ -23,12 +29,6 @@ public class Meeting : Entity, IAggregateRoot
 
         private MeetingLocation _location;
 
-        private List<MeetingAttendee> _attendees;
-
-        private List<MeetingNotAttendee> _notAttendees;
-
-        private List<MeetingWaitlistMember> _waitlistMembers;
-
         private MeetingLimits _meetingLimits;
 
         private Term _rsvpTerm;
@@ -51,9 +51,9 @@ public class Meeting : Entity, IAggregateRoot
 
         private Meeting()
         {
-            _attendees = new List<MeetingAttendee>();
-            _notAttendees = new List<MeetingNotAttendee>();
-            _waitlistMembers = new List<MeetingWaitlistMember>();
+            _attendees = [];
+            _notAttendees = [];
+            _waitlistMembers = [];
         }
 
         internal static Meeting CreateNew(
@@ -106,9 +106,9 @@ private Meeting(
             _creatorId = creatorId;
             _createDate = SystemClock.Now;
 
-            _attendees = new List<MeetingAttendee>();
-            _notAttendees = new List<MeetingNotAttendee>();
-            _waitlistMembers = new List<MeetingWaitlistMember>();
+            _attendees = [];
+            _notAttendees = [];
+            _waitlistMembers = [];
 
             this.AddDomainEvent(new MeetingCreatedDomainEvent(this.Id));
             var rsvpDate = SystemClock.Now;

src/Modules/Meetings/Infrastructure/Configuration/Processing/Outbox/OutboxModule.cs

@@ -40,7 +40,7 @@ private void CheckMappings()
                 .Where(x => x.GetInterfaces().Contains(typeof(IDomainEventNotification)))
                 .ToList();
 
-            List<Type> notMappedNotifications = new List<Type>();
+            List<Type> notMappedNotifications = [];
             foreach (var domainEventNotification in domainEventNotifications)
             {
                 _domainNotificationsMap.TryGetBySecond(domainEventNotification, out var name);

src/Modules/Meetings/Tests/ArchTests/Application/ApplicationTests.cs

@@ -122,7 +122,7 @@ public void InternalCommand_Should_Have_Constructor_With_JsonConstructorAttribut
                 .Inherit(typeof(InternalCommandBase<>))
                 .GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
 
             foreach (var type in types)
             {
@@ -155,7 +155,7 @@ public void MediatR_RequestHandler_Should_NotBe_Used_Directly()
                 .Should().ImplementInterface(typeof(IRequestHandler<>))
                 .GetTypes();
 
-            List<Type> failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in types)
             {
                 bool isCommandHandler = type.GetInterfaces().Any(x =>
@@ -184,7 +184,7 @@ public void Command_With_Result_Should_Not_Return_Unit()
                 .That().ImplementInterface(commandWithResultHandlerType)
                 .GetTypes().ToList();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (Type type in types)
             {
                 Type interfaceType = type.GetInterface(commandWithResultHandlerType.Name);

src/Modules/Meetings/Tests/ArchTests/Domain/DomainTests.cs

@@ -45,7 +45,7 @@ public void Entity_Which_Is_Not_Aggregate_Root_Cannot_Have_Public_Members()
                                               BindingFlags.Instance |
                                               BindingFlags.Static;
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in types)
             {
                 var publicFields = type.GetFields(bindingFlags);
@@ -75,7 +75,7 @@ public void Entity_Cannot_Have_Reference_To_Other_AggregateRoot()
                                               BindingFlags.NonPublic |
                                               BindingFlags.Instance;
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in entityTypes)
             {
                 var fields = type.GetFields(bindingFlags);
@@ -112,7 +112,7 @@ public void Entity_Should_Have_Parameterless_Private_Constructor()
                 .That()
                 .Inherit(typeof(Entity)).GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var entityType in entityTypes)
             {
                 bool hasPrivateParameterlessConstructor = false;
@@ -144,7 +144,7 @@ public void Domain_Object_Should_Have_Only_Private_Constructors()
                         .Inherit(typeof(ValueObject))
                 .GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var domainObjectType in domainObjectTypes)
             {
                 var constructors = domainObjectType.GetConstructors(BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance);
@@ -167,7 +167,7 @@ public void ValueObject_Should_Have_Private_Constructor_With_Parameters_For_His_
                 .That()
                 .Inherit(typeof(ValueObject)).GetTypes();
 
-            var failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var entityType in valueObjects)
             {
                 bool hasExpectedConstructor = false;

src/Modules/Meetings/Tests/ArchTests/SeedWork/TestBase.cs

@@ -17,7 +17,7 @@ public abstract class TestBase
 
         protected static void AssertAreImmutable(IEnumerable<Type> types)
         {
-            IList<Type> failingTypes = new List<Type>();
+            List<Type> failingTypes = [];
             foreach (var type in types)
             {
                 if (type.GetFields().Any(x => !x.IsInitOnly) || type.GetProperties().Any(x => x.CanWrite))

src/Modules/Meetings/Tests/IntegrationTests/Meetings/MeetingHelper.cs

@@ -54,7 +54,7 @@ await meetingsModule.ExecuteCommandAsync(
                     null,
                     null,
                     null,
-                    new List<Guid> { executionContext.UserId }));
+                    [executionContext.UserId]));
 
             return meetingId;
         }