fix(GoogleCloudPlatform#189): Change the way to return repo name as p…

…revious logic doesn't work
khhini · Oct 12, 2024 · 88f1691 · 88f1691
1 parent 9910872
commit 88f1691
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/githubissues/main.go b/githubissues/main.go
@@ -150,12 +150,10 @@ func (g *githubissuesNotifier) SendNotification(ctx context.Context, build *cbpb
 }
 
 func GetGithubRepo(configGithubRepo string, build *cbpb.Build) string {
-	if build.Substitutions != nil {
-		if repo, ok := build.Substitutions["REPO_FULL_NAME"]; ok {
-			// return repo full name if it's available
-			// e.g. "GoogleCloudPlatform/cloud-build-notifiers"
-			return repo
-		}
+	if build.Substitutions != nil && build.Substitutions["REPO_FULL_NAME"] != "" {
+		// return repo full name if it's available
+		// e.g. "GoogleCloudPlatform/cloud-build-notifiers"
+		return build.Substitutions["REPO_FULL_NAME"]
 	}
 	return configGithubRepo
 }