Improve Obsidian Sync for Large Vaults #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debanjum
commented
Jan 12, 2025
debanjum
commented
- Batch sync files by size to try not exceed API request payload size limits
- Fix force sync of large vaults from Obsidian
- Add API endpoint to delete all indexed files by file type
This may help mitigate the issue #970
Previously if you tried to force sync a vault with more than 1000 files it would only end up keeping the last batch because the PUT API call would delete all previous entries. This change ensures the PUT call is only made for the first batch of a force sync (regenerate) request. The rest of the API calls are PATCH, so they do not delete files from the previous batches
…nc-for-large-vaults
sabaimran
reviewed
Jan 21, 2025
| @@ -325,6 +325,29 @@ def get_content_types(request: Request, client: Optional[str] = None): | |||
| return list(configured_content_types & all_content_types) | |||
|
|
|||
|
|
|||
| @api_content.delete("/{content_type}", status_code=200) | |||
There was a problem hiding this comment.
This API spec conflicts with out other delete endpoint, as below:
@api_content.get("/{content_source}", response_model=List[str])
I'd suggest we just use the existing deletion endpoint, and send it with type computer rather than specifying file types. Ideally, we should differentiate with Obsidian here, but that might be a bigger discussion.
We could also extend the existing API to take in content_type and content_source as query parameters, rather than path paremeters.
sabaimran
requested changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.