test(create-plugin): add test cases for JsSdkTest-5,6,7,8

[hung-cybo]

Why

• Increase the reliability of create-plugin package.

What

• Add test case JsSdkTest-5, JsSdkTest-6, JsSdkTest-7, JsSdkTest-8

How to test

pnpm test:e2e

Checklist

• Read CONTRIBUTING.md
• Updated documentation if it is required.
• Added tests if it is required.
• Passed pnpm lint and pnpm test on the root directory.

[aws-amplify-ap-northeast-1]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2763.d1ite8zvzg8c5i.amplifyapp.com

[tuanphamcybozu]

@hung-cybo
Can we make these import shorter and cleaner, something like this:

// e2e.test.ts
import {
  requiredOptions,
  pluginNameContain64Chars,
  pluginDescriptionContain200Chars,
  allOptions,
  languageEN,
  languageJA,
  emptyOutputDir,
  pluginNameContain65Chars,
  pluginDescriptionContain201Chars,
  existOutputDir,
  createKintonePluginCommand,
  minimumTemplate,
  modernTemplate,
} from "./fixtures";

// fixtures/index.ts
export { pattern as requiredOptions } from "./requiredOptions";
export { pattern as pluginNameContain64Chars } from "./pluginNameContain64Chars";
export { pattern as pluginDescriptionContain200Chars } from "./pluginDescriptionContain200Chars";
export { pattern as allOptions } from "./allOptions";
export { pattern as languageEN } from "./languageEN";
export { pattern as languageJA } from "./languageJA";
export { pattern as emptyOutputDir } from "./emptyOutputDir";
export { pattern as pluginNameContain65Chars } from "./pluginNameContain65Chars";
export { pattern as pluginDescriptionContain201Chars } from "./pluginDescriptionContain201Chars";
export { pattern as existOutputDir } from "./existOutputDir";
export { pattern as createKintonePluginCommand } from "./createKintonePluginCommand";
export { pattern as minimumTemplate } from "./minimumTemplate";
export { pattern as modernTemplate } from "./modernTemplate";

[hung-cybo]

@tuanphamcybozu

With your suggestion, the problem was moved from e2e.test.ts to fixtures/index.ts, but this does not completely resolve the problem.
In addition, when a new test case is created, we have to import it to fixtures/index.ts first, then e2e.test.ts instead of using it directly.

Do you have any other suggestions?

[tuanphamcybozu]

@hung-cybo
This is called barrel. It's useful when your code is bigger and bigger.
Ref: https://medium.com/suyeonme/barrel-adding-barrel-into-typescript-7141a6ac9003

But I leave the change or not to you.

[hung-cybo]

@tuanphamcybozu

Thank you for your sharing. I've not heard about the barrel concept.
I found another topic that talks about the disadvantages of the barrel concept.
https://dev.to/tassiofront/barrel-files-and-why-you-should-stop-using-them-now-bc4

However, in our case, I think we can apply this concept.

[tuanphamcybozu]

@hung-cybo
Is it cleaner when initialize the value in field?

  private currentStep: number = 0;
  private _stdout: string = "";
  private _stderr: string = "";

[tuanphamcybozu]

@hung-cybo
Currently, using underscore and not using, is not synchrous in fields declaration.
This reference recommend not using underscore in this case:

https://google.github.io/styleguide/tsguide.html#naming-style

Do not use trailing or leading underscores for private properties or methods.

[tuanphamcybozu]

@hung-cybo
Lack of access modifier, not necessary but it should be synchronous with other methods.

[tuanphamcybozu]

@hung-cybo
Is it used in any places?

[tuanphamcybozu]

LGTM