Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pnpm start script on the root directory #2865

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 8, 2024

Why

Trying the command, pnpm run start, on the root directory, the error is faced as below:

packages/plugin-packer postbuild: ERROR: Invalid Option: --watch
packages/rest-api-client postbuild: ERROR: Invalid Option: --watch
packages/plugin-packer postbuild: Failed
js-sdk/packages/plugin-packer:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kintone/plugin-packer@8.1.3 postbuild: `run-p js css "--watch"`
Exit status 1
packages/rest-api-client postbuild: Failed

What

Problem:
When the root start script (pnpm build --watch) was executed, pnpm prebuild && tsc --build packages --force && pnpm postbuild "--watch" was actually executed.
The postbuild script for rest-api-client package and plugin-packer package did not support the "--watch" option.

Solution:
Because children packages have each start script, modify the start script for root package.json to run all child package start scripts in parallel.

How to test

run pnpm start on the root directory

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@shabaraba shabaraba self-assigned this Jul 8, 2024
@shabaraba shabaraba changed the title fix: fix script for pnpm run start on the root directory fix: fix pnpm start script on the root directory Jul 8, 2024
@shabaraba shabaraba marked this pull request as ready for review July 8, 2024 01:21
@shabaraba shabaraba requested a review from tasshi-me July 8, 2024 01:27
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit 66c220c into main Jul 9, 2024
17 checks passed
@tasshi-me tasshi-me deleted the fix/pnpm-start branch July 9, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants