Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest-api-client): rename moveToSpace method to move #2872

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix(rest-api-client): rename moveToSpace method to move #2872

merged 3 commits into from
Jul 12, 2024

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 11, 2024 •
edited
Loading

Why

The method name moveToSpace can be misleading.
In fact, it not only changes the space, but also removes the space.

What

  • change the moveToSpace method name to move

How to test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jul 11, 2024
@shabaraba shabaraba force-pushed the refactor/change-move-method-name branch from 3ce2ac6 to affb4d9 Compare July 11, 2024 07:01
@shabaraba shabaraba marked this pull request as ready for review July 11, 2024 07:06
@shabaraba shabaraba requested a review from tasshi-me July 11, 2024 07:09
@shabaraba shabaraba self-assigned this Jul 11, 2024
tasshi-me
tasshi-me approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me changed the title refactor(rest-api-client): change move method name: moveToSpace to move fix(rest-api-client): rename moveToSpace method to move Jul 11, 2024
@tasshi-me tasshi-me merged commit ca902a7 into main Jul 12, 2024
17 checks passed
@tasshi-me tasshi-me deleted the refactor/change-move-method-name branch July 12, 2024 01:46
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees

@shabaraba shabaraba

Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shabaraba @tasshi-me