Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rest-api-client): delete rest-api-client-demo #2875

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore(rest-api-client): delete rest-api-client-demo #2875

merged 2 commits into from
Jul 17, 2024

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jul 12, 2024 •
edited
Loading

Why

  • Unclear about the operation of examples.
  • There doesn't seem the target users.

What

  • Delete the examples directory.

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@shabaraba shabaraba self-assigned this Jul 12, 2024
@shabaraba shabaraba marked this pull request as ready for review July 12, 2024 04:46
@shabaraba shabaraba requested a review from tasshi-me July 12, 2024 04:54
@shabaraba shabaraba force-pushed the refactor/delete-examples-dir branch from 3faf5aa to 88e1574 Compare July 12, 2024 05:04
@shabaraba shabaraba changed the title refactor(rest-api-client): delete rest-api-client-demo chore(rest-api-client): delete rest-api-client-demo Jul 12, 2024
tasshi-me
tasshi-me approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit 650d795 into main Jul 17, 2024
17 checks passed
@tasshi-me tasshi-me deleted the refactor/delete-examples-dir branch July 17, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees

@shabaraba shabaraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shabaraba @tasshi-me