Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): add README.md #3124

Open
wants to merge 4 commits into
base: feat/add-rest-js
Choose a base branch
from

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jan 9, 2025

Why

What

How to test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@shabaraba shabaraba force-pushed the feat/add-rest-js-readme branch from 5f33054 to a17272c Compare January 10, 2025 01:23
@shabaraba shabaraba marked this pull request as ready for review January 14, 2025 01:11
@shabaraba shabaraba requested a review from a team as a code owner January 14, 2025 01:11
@shabaraba shabaraba requested review from chihiro-adachi and tasshi-me and removed request for a team January 14, 2025 01:11
"X-Cybozu-Authorization": procecc.env.KINTONE_AUTHORIZATION,
// Use API token authentication
// auth: { apiToken: process.env.KINTONE_API_TOKEN }
// "X-Cybozu-API-Token": procecc.env.KINTONE_AUTHORIZATION,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shabaraba
↓が正?
// Use API token authentication
// "X-Cybozu-API-Token": procecc.env.KINTONE_API_TOKEN,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chihiro-adachi
ありがとうございます、そちらが正しいので修正しました!

@@ -57,8 +57,7 @@ const client = createClient<paths>({
headers: {
"X-Cybozu-Authorization": procecc.env.KINTONE_AUTHORIZATION,
// Use API token authentication
// auth: { apiToken: process.env.KINTONE_API_TOKEN }
// "X-Cybozu-API-Token": procecc.env.KINTONE_AUTHORIZATION,
// "X-Cybozu-API-Token": procecc.env.KINTONE_API_TOKEN,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

procecc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants