Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Set Start from Player action, so that it can move a whole selection of subtitles. #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eltomito
Copy link

The anctent Set Start From Player action moves the selected subtitle to the current player position.
But when more than 1 subtitles are selected, it just moves the first one anyway.
This is where this pull request comes to the rescue and saves the day:
It makes this action move all the selected subtitles to the new player position as a block... and then walks off into the sunset.

@felagund
Copy link
Collaborator

Hm, I am not sure if it did not make more sense to move the suceeding subtitles by the same amount. Ergo lets say we have subtitles A B and C starting at 0:00:01,000, 0:00:02,000 and 0:00:03,000 respectively. Lets say we have the player at position 0:00:04,000. Set start from player would then set the new starts to 0:00:04,000, 0:00:05,000 and 0:00:06,000 respecitvely.

Why would you want to have many subtitles start at the same time?

@eltomito
Copy link
Author

eltomito commented Sep 22, 2021 via email

@felagund
Copy link
Collaborator

Great! This would implement "move subtitles to position" which is now possible with cuting and pasting them but it is slowish (a few seconds of lag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants