NavigationBar padding updates #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-domi-navbar-updates.surge.sh |
|
Size Change: +14 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
f6fcdd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5470683c.orbit.pages.dev |
| Branch Preview URL: | https://domi-navbar-updates.orbit.pages.dev |
domihustinova
force-pushed
the
domi/navbar-updates
branch
2 times, most recently
from
a0df190 to
13c1d0a
Compare
domihustinova
commented
Jan 10, 2025
| @@ -74,7 +74,7 @@ const NavigationBar = ({ | |||
| )} | |||
| aria-label={ariaLabel} | |||
| > | |||
| <div className="me-200 block w-full">{children}</div> | |||
| <div className={cx("block w-full", onMenuOpen && "me-200")}>{children}</div> | |||
There was a problem hiding this comment.
I added this condition for the margin as it doesn't make sense to me for it to be there if there is no menu link rendered but I might be missing some information why it's there.
There was a problem hiding this comment.
To be honest I don't know. I think it makes sense what you did.
It's actually affecting production by adding margin on the right side 😬
There was a problem hiding this comment.
We have confirmation from the designers to remove the margin.
domihustinova
force-pushed
the
domi/navbar-updates
branch
from
24a1f92 to
d88d9ed
Compare
domihustinova
changed the title
domihustinova
force-pushed
the
domi/navbar-updates
branch
2 times, most recently
from
f7ca212 to
8eaa4ed
Compare
mvidalgarcia
approved these changes
Jan 14, 2025
domihustinova
force-pushed
the
domi/navbar-updates
branch
from
8eaa4ed to
f6fcdd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of FEPLT-2191
Horizontal padding for mobile sizes changed to 16px as requested, vertical padding kept at original value.
✨
Description by Callstackai
This PR updates the horizontal padding for mobile sizes in the
NavigationBarcomponent to 16px and retains the original vertical padding.Diagrams of code changes
sequenceDiagram participant User participant NavigationBar participant ButtonLink Note over NavigationBar: Updated styling:<br/>- Fixed position at top<br/>- White background<br/>- Padding adjustments<br/>- Transition animations User->>NavigationBar: View component alt Navigation bar shown NavigationBar->>NavigationBar: Apply translate-y-0 else Navigation bar hidden NavigationBar->>NavigationBar: Apply negative translation end alt onMenuOpen is true NavigationBar->>ButtonLink: Render menu button end Note over NavigationBar: Content wrapped in div<br/>with margin adjustment<br/>when menu is openFiles Changed