Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation annotations to CleanupConfig #303

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add validation annotations to CleanupConfig #303

merged 1 commit into from
Oct 26, 2023

Conversation

sleberknight
Copy link
Member

  • Update the version in the POM to 2.1.0-SNAPSHOT
  • Add dropwizard-validation and jakarta.validation-api as explicit dependencies, since we're using both standard Jakarta annotations and a Dropwizard one
  • Make all references types @NotNull in CleanupConfig
  • Make all Duration types @MinDuration of 1 minute
  • Add a bunch of tests, and enhance the existing test of default values

Closes #302

@sleberknight
Add validation annotations to CleanupConfig
22ebd7f 
* Update the version in the POM to 2.1.0-SNAPSHOT
* Add dropwizard-validation and jakarta.validation-api as explicit
  dependencies, since we're using both standard Jakarta annotations
  and a Dropwizard one
* Make all references types @NotNull in CleanupConfig
* Make all Duration types @MinDuration of 1 minute
* Add a bunch of tests, and enhance the existing test of default values

Closes #302
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chrisrohr chrisrohr merged commit 7493b84 into master Oct 26, 2023
6 checks passed
@chrisrohr chrisrohr deleted the 302-add-validation-annotations-to-CleanupConfig branch October 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrohr chrisrohr chrisrohr approved these changes

Assignees

@chrisrohr chrisrohr

@sleberknight sleberknight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation annotations to CleanupConfig
2 participants
@sleberknight @chrisrohr