-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plain JDBC ApplicationErrorDao implementation #316
Merged
sleberknight
merged 3 commits into
master
from
248-add-plain-JDBC-implementation-of-ApplicationErroDao
Nov 18, 2023
Merged
Add plain JDBC ApplicationErrorDao implementation #316
sleberknight
merged 3 commits into
master
from
248-add-plain-JDBC-implementation-of-ApplicationErroDao
Nov 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add JdbcApplicationErrorDao, a plain JDBC implementation of ApplicationErrorDao * Since the logic to map from a ResultSet is identical for the JDBC and JDBI implementations, move that logic from the Jdbi3ApplicationErrorRowMapper into ApplicationErrorJdbc in a new method 'mapFrom(ResultSet)'. Also, fix how the port is set, using rs.getInt instead of intValueOrNull, since the port field in ApplicationError is an int, not Integer * Add new constructor accepting only a Throwable to ApplicationErrorJdbc.ApplicationErrorJdbcException * Add several new helper methods to ApplicationErrorJdbc for the JDBC implementation, nextOrThrow and shutdownH2Database * Add abstract base test class, AbstractJdbcApplicationErrorDaoTest, and two subclasses for testing against H2 and Postgres * Make sure to shut down the in-memory H2 database in both H2Jdbi3ApplicationErrorDaoTest and H2JdbcApplicationErrorDaoTest. Otherwise, if the H2 JDBI test runs after the JDBC one, the tests fail because they expect the database to be empty. By shutting the in-memory database down, we ensure the tests are completely isolated. Misc: * Remove two redundant warning suppression annotations from ErrorContextUtilitiesTest Closes #248
dsingley
approved these changes
Nov 13, 2023
sleberknight
commented
Nov 15, 2023
src/main/java/org/kiwiproject/dropwizard/error/dao/ApplicationErrorJdbc.java
Outdated
Show resolved
Hide resolved
src/main/java/org/kiwiproject/dropwizard/error/dao/jdk/JdbcApplicationErrorDao.java
Show resolved
Hide resolved
src/main/java/org/kiwiproject/dropwizard/error/dao/jdk/JdbcApplicationErrorDao.java
Show resolved
Hide resolved
src/main/java/org/kiwiproject/dropwizard/error/dao/jdk/JdbcApplicationErrorDao.java
Show resolved
Hide resolved
src/main/java/org/kiwiproject/dropwizard/error/dao/ApplicationErrorJdbc.java
Show resolved
Hide resolved
src/main/java/org/kiwiproject/dropwizard/error/dao/jdk/JdbcApplicationErrorDao.java
Show resolved
Hide resolved
src/test/java/org/kiwiproject/dropwizard/error/dao/jdk/AbstractJdbcApplicationErrorDaoTest.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
sleberknight
deleted the
248-add-plain-JDBC-implementation-of-ApplicationErroDao
branch
November 18, 2023 03:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc:
Closes #248