Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nextOrThrow in ApplicationErrorJdbc with one from KiwiJdbc #329

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Replace nextOrThrow in ApplicationErrorJdbc with one from KiwiJdbc #329

merged 1 commit into from
Nov 26, 2023

Conversation

sleberknight
Copy link
Member

  • Replace usages of ApplicationErrorJdbc#nextOrThrow with the one from KiwiJdbc
  • Remove the nextOrThrow method from ApplicationErrorJdbc; this was never in an actual release so doesn't break any existing code and doesn't require a major version bump
  • Remove the nextOrThrow tests from ApplicationErrorJdbcTest; we don't need to test it anymore since it's now the one in KiwiJdbc

Closes #321

@sleberknight
Replace nextOrThrow in ApplicationErrorJdbc with one from KiwiJdbc
c900f79 
* Replace usages of ApplicationErrorJdbc#nextOrThrow with the
  one from KiwiJdbc
* Remove the nextOrThrow method from ApplicationErrorJdbc; this
  was never in an actual release so doesn't break any existing code
  and doesn't require a major version bump
* Remove the nextOrThrow tests from ApplicationErrorJdbcTest; we
  don't need to test it anymore since it's now the one in KiwiJdbc

Closes #321
@sleberknight sleberknight self-assigned this Nov 26, 2023
@sleberknight sleberknight marked this pull request as ready for review November 26, 2023 16:20
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit 12b8603 into master Nov 26, 2023
6 checks passed
@sleberknight sleberknight deleted the 321-use-nextOrThrow-from-KiwiJdbc branch November 26, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ApplicationErrorJdbc's nextOrThrow method with the one from KiwiJdbc
1 participant
@sleberknight