Why do we need to create the ZimFileReader object and set it to the reader if we open the note for the file that is not currently opened in the reader.

[MohitMaliFtechiz]

Describe the bug
Why do we need to create the ZimFileReader object and set it to the reader if we open the note for the file that is not currently opened in the reader? Since when opening the note user only wants to see or edit the current note. For this, we have all the things already available in the database like filePath, noteTitle, and ZimUrl, etc, and we only need these things to update the note so why are we creating the ZimFileReader object and setting it to the reader? IMHO, we should not create the ZimFileReader and set it to the current reader because the user only wants to open or edit the note, and creating the ZimFileReader is a resource-intensive task because there can be huge ZIM files. Also, it does not make sense to set the ZIM file in reader for the currently opened note because there is one more option "OPEN ARTICLE" which directly opens the ZIM file and loads the page of note.

See

kiwix-android/core/src/main/java/org/kiwix/kiwixmobile/core/page/notes/viewmodel/effects/ShowOpenNoteDialog.kt

Line 61 in 6272219

zimReaderContainer.setZimReaderSource(item.zimReaderSource)

Expected behavior
It should not create the ZimFileReader as it is a resource-intensive task and we are doing it for no reason.

Environment

• Version of Kiwix Android : 3.13.0

[MohitMaliFtechiz]

@kelson42 While fixing the #3937 I found this issue. I see no good reason for creating ZimFileReader and setting it to the current reader. It was introduced very long ago do you think it is still a good idea?

[kelson42]

@MohitMaliFtechiz Your remark seems legit to me at a first look.

[MohitMaliFtechiz]

@kelson42 Thanks for your feedback. I am refactoring the code to avoid creating the ZimFileReader while opening notes on the note screen.