Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the unnecessary creation of ZimFileReader when opening notes on the Notes screen. #4183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4180

  • Removed the unnecessary creation of ZimFileReader when opening notes on the Notes screen.
  • Refactored AddNoteDialog to use database values for performing note-related operations (e.g., view, edit, delete notes) instead of setting and using ZimFileReader.
screen-20250121-155323.mp4

…on the Notes screen.

* Refactored `AddNoteDialog` to use database values for performing note-related operations (e.g., view, edit, delete notes) instead of setting and using `ZimFileReader`.
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 52.17391% with 22 lines in your changes missing coverage. Please review.

Project coverage is 56.78%. Comparing base (6272219) to head (7321e1a).

Files with missing lines Patch % Lines
...a/org/kiwix/kiwixmobile/core/main/AddNoteDialog.kt 45.94% 2 Missing and 18 partials ⚠️
...x/kiwixmobile/core/page/viewmodel/PageViewModel.kt 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4183      +/-   ##
============================================
- Coverage     56.88%   56.78%   -0.11%     
  Complexity     1526     1526              
============================================
  Files           313      313              
  Lines         13455    13442      -13     
  Branches       1674     1676       +2     
============================================
- Hits           7654     7633      -21     
- Misses         4645     4654       +9     
+ Partials       1156     1155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants