Fixed: Some EPUB files are not downloading. #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3738 +/- ##
============================================
- Coverage 53.86% 53.78% -0.08%
- Complexity 1376 1377 +1
============================================
Files 298 299 +1
Lines 11308 11333 +25
Branches 1495 1495
============================================
+ Hits 6091 6096 +5
- Misses 4226 4246 +20
Partials 991 991 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
force-pushed
the
Fix#3737
branch
from
e19c591 to
c9eba34
Compare
Sagar0-0
reviewed
Mar 16, 2024
|
@Sagar0-0 It will show the toast error message if no PDF/Epub Reader application is installed on the mobile device. |
MohitMaliFtechiz
force-pushed
the
Fix#3737
branch
from
29c7faa to
2fbcb0b
Compare
|
@MohitMaliDeveloper CI Failed again!!! |
1 similar comment
|
@MohitMaliDeveloper CI Failed again!!! |
MohitMaliFtechiz
force-pushed
the
Fix#3737
branch
from
af8860e to
da88313
Compare
* The issue was epub fileName containing the colon ":" in it that is not supported by most of fileSystem, that's why it is not creating the file in fileSystem and we are not able to download the epub file. * So to fix this we have improved our `getDecodedFileName` method which returns the fileName of the epub file, here we are removing the colon from fileName if any contains. For this change we have added the test cases as well for our `getDecodedFileName` function to properly test it. * We also refined our downloadFileFromUrl method. Previously, the generateSequence function was used to create new files with underscores and incremented numbers, anticipating multiple attempts to save the same file. However, since we now save files only once in our storage, this feature is no longer utilized. This enhancement is detailed in issue #2879. * Added epub query in our manifest to properly open epub files in external application.
* This was requested in #3453 and this PR is related to the Epub opening issue so we are introducing this here.
…e scenarios e.g. "Download Failed", "Download Successfull", "When no reader application is installed in device", "File opens in external reader application", "When user clicks on NO Thanks button".
* Improved the dialog's message and title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3737
Fixes #3453
getDecodedFileNamemethod which returns the fileName of the epub file, here we are removing the colon from fileName if any contains. For this change, we have added the test cases as well for ourgetDecodedFileNamefunction to test it properly.EPubNotOpening.mp4
EPUBOpeningIssueFixed.mp4
screen-20240606-142648.mp4