Fixed: After restoring the tab it hides a few area of the article from the top. #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3743 +/- ##
=========================================
Coverage 52.24% 52.25%
- Complexity 1270 1272 +2
=========================================
Files 292 292
Lines 10977 10975 -2
Branches 1454 1451 -3
=========================================
Hits 5735 5735
- Misses 4286 4288 +2
+ Partials 956 952 -4 ☔ View full report in Codecov by Sentry. |
|
@MohitMaliDeveloper Sorry but it seems the CI for 33 is still unstable... or broken? |
…m the top. * It was showing with the top margin we have set in `TabsAdapter` for not showing the top margin in tabs, and `tempWebViewForUndo` saved with that margin, so when we are showing this in our reader, it was showing with that margin. So to fix this we are removing this margin from the `tempWebViewForUndo` if `tabSwitcher` is not showing, for properly showing the webView content. If the tab switcher is showing it will work as before. * Used the `safelyAddWebView` method when we were selecting the tab as this method is doing the same that we are doing in `selectTab` method so to reduce duplicate code we used this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3741
TabsAdapterfor not showing the top margin in tabs, andtempWebViewForUndosaved with that margin, so when we are showing this in our reader, it was showing with that margin. So to fix this we are removing this margin from thetempWebViewForUndoiftabSwitcheris not showing, for properly showing the webView content. If the tab switcher is showing it will work as before.safelyAddWebViewmethod when we were selecting the tab as this method is doing the same that we are doing inselectTabmethod so to reduce duplicate code we used this method.TabsIssueWhileUndo.mp4
TabIssueFix.mp4