Migrate totalSpace to IO Thread #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CalebKL Ready to review? |
CalebKL
force-pushed
the
caleb/task/migrate-total-space-to-io-thread
branch
from
af58544 to
a71bc12
Compare
Yes. I have already talked to @MohitMaliFtechiz. |
|
@CalebKL Thanks, i will review it soon. |
MohitMaliFtechiz
requested changes
Dec 4, 2024
There was a problem hiding this comment.
@CalebKL Please rebase, and resolve the conflicts, and see the review comments.
app/src/androidTest/java/org/kiwix/kiwixmobile/ObjectBoxToRoomMigratorTest.kt
Outdated
Show resolved
Hide resolved
MohitMaliFtechiz
previously approved these changes
Dec 5, 2024
|
@CalebKL Please resolve the conflicts by rebasing the PR. There are some conflicts due to merge commits.
|
CalebKL
force-pushed
the
caleb/task/migrate-total-space-to-io-thread
branch
from
af1a17a to
a43ab91
Compare
MohitMaliFtechiz
approved these changes
Dec 6, 2024
kelson42
force-pushed
the
caleb/task/migrate-total-space-to-io-thread
branch
from
a23c2bb to
63e3513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4038
This PR, moves
totalSpaceto the IO Thread and removes runBlocking which was blocking the main thread.Screenshots