-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add widget support #797
Open
juuz0
wants to merge
6
commits into
main
Choose a base branch
from
widgetEndpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add widget support #797
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
489dfc1
Give a name to function for updating book count
juuz0 efe42c9
Add widget endpoint
juuz0 d27220f
Give name to IIFE in index.js and expose updateBookCount
juuz0 58c04b3
Basic widget handling
juuz0 09dc6f9
Add custom CSS and JS support
juuz0 fc87def
Add documentation for widget
juuz0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,87 @@ | ||
// To be updated | ||
function disableSearchFilters(widgetStyles) { | ||
const hideNavRule = ` | ||
.kiwixNav { | ||
display: none; | ||
}`; | ||
const hideResultsLabelRule = ` | ||
.kiwixHomeBody__results { | ||
display: none; | ||
}`; | ||
const hideTagFilterRule = ` | ||
.book__tags { | ||
pointer-events: none; | ||
}`; | ||
insertNewCssRules(widgetStyles, [hideNavRule, hideResultsLabelRule, hideTagFilterRule]); | ||
} | ||
Comment on lines
+1
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that if you introduce custom CSS handling first, then |
||
|
||
function disableBookClick() { | ||
kiwixServe.disableBookClick(); | ||
} | ||
|
||
function disableDownload(widgetStyles) { | ||
const hideBookDownloadRule = ` | ||
.book__download { | ||
display: none; | ||
}`; | ||
insertNewCssRules(widgetStyles, [hideBookDownloadRule]); | ||
} | ||
|
||
function disableDescription(widgetStyles) { | ||
const decreaseHeightRule = ` | ||
.book__wrapper { | ||
height:128px; | ||
grid-template-rows: 70px 0 1fr 1fr; | ||
}`; | ||
const hideDescRule = ` | ||
.book__description { | ||
display: none; | ||
}`; | ||
insertNewCssRules(widgetStyles, [decreaseHeightRule, hideDescRule]); | ||
} | ||
|
||
function hideFooter(widgetStyles) { | ||
const hideFooterRule = ` | ||
.kiwixfooter { | ||
display: none !important; | ||
}`; | ||
insertNewCssRules(widgetStyles, [hideFooterRule]); | ||
} | ||
|
||
function insertNewCssRules(stylesheet, ruleList) { | ||
if (stylesheet) { | ||
for (rule of ruleList) { | ||
stylesheet.insertRule(rule, 0); | ||
} | ||
} | ||
} | ||
|
||
function handleWidget() { | ||
const params = new URLSearchParams(window.location.search || filters || ''); | ||
const widgetStyleElem = document.createElement('style'); | ||
document.head.appendChild(widgetStyleElem); | ||
|
||
const widgetStyles = widgetStyleElem.sheet; | ||
|
||
const disableFilters = params.has('disablefilter'); | ||
const disableClick = params.has('disableclick'); | ||
const disableDwld = params.has('disabledownload'); | ||
const disableDesc = params.has('disabledesc'); | ||
|
||
const blankBase = document.createElement('base'); | ||
blankBase.target = '_blank'; | ||
document.head.appendChild(blankBase); // open all links in new tab | ||
|
||
if (disableFilters) | ||
disableSearchFilters(widgetStyles); | ||
if (disableClick) | ||
disableBookClick(); | ||
if (disableDwld) | ||
disableDownload(widgetStyles); | ||
if (disableDesc) | ||
disableDescription(widgetStyles); | ||
|
||
hideFooter(widgetStyles); | ||
kiwixServe.updateBookCount(); | ||
} | ||
|
||
handleWidget(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
nodeQueryElem == null
doesn't theloadAndDisplayOptions()
function become a no-op? If so why runfetch(query)
at all?