Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change source package path from io.kixi.* to io.kixi.core.* #4

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

SingingBush
Copy link
Contributor

I intend to setup JPMS for both Ki Core and Ki KD but as a precursor it would be wise to make sure that the package name not be to broad. The reason being that split packages are not allowed with the Java module system. Therefore this PR is to move all code in this project from io.kixi.* to io.kixi.core.*.

As this is a breaking change, I'll wait for you to confirm that you're happy to proceed before merging. Once done then the module-info should be something like:

module kixi.ki.core {
    requires kotlin.stdlib;
    requires kotlin.stdlib.jdk8;

    exports io.kixi.core;
    exports io.kixi.core.text;
    exports io.kixi.core.uom;
}

@SingingBush SingingBush requested a review from dleuck April 28, 2022 21:20
@SingingBush SingingBush changed the title move from io.kixi.* to io.kixi.core.* change source package path from io.kixi.* to io.kixi.core.* Apr 28, 2022
@SingingBush SingingBush force-pushed the change_packagename branch 2 times, most recently from 63b4d5d to d5be4f2 Compare February 11, 2024 10:29
@SingingBush SingingBush merged commit a9865f2 into master Feb 11, 2024
4 checks passed
@SingingBush SingingBush deleted the change_packagename branch February 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant