uv17pro: Fix exposing static banks on some models #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in commit:5d295a8b we added a static bank model to show the static mappings between memories and "banks" in these radios. However, only some of the more advanced models have this functionality, not all the radios that inherit from UV17Pro. This fixes that to only apply this model to the UV17ProGPS and BF-F8HP-PRO models. Further, in commit:d1f8504e we fixed the bug where the UV17 models inherited this behavior to disable it for them. Those overrides are no longer necessary, so this removes them. Related to #11642
kk7ds
force-pushed
the
fix-uv17-static-banks
branch
from
662c280 to
4e91812
Compare
|
Okay @KC9HI I think this cleans up my mess. |
|
Yes @kk7ds I think this is what was needed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in commit:5d295a8b we added a static bank model to show
the static mappings between memories and "banks" in these radios.
However, only some of the more advanced models have this functionality,
not all the radios that inherit from UV17Pro. This fixes that to only
apply this model to the UV17ProGPS and BF-F8HP-PRO models.
Further, in commit:d1f8504e we fixed the bug where the UV17 models
inherited this behavior to disable it for them. Those overrides are
no longer necessary, so this removes them.
Related to #11642