Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft450: Fix IF filter setting breaking UI #804

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

kk7ds
Copy link
Owner

@kk7ds kk7ds commented Nov 5, 2023

This driver exposed a different setting for each memory in extra
depending on the mode of that memory. That's not compatible with the
UI's exploding of extra fields into columns, and in general breaks
the ability to edit a whole memory in the properties dialog.

This makes it expose one setting with all the available options, but
ensures that only filters valid for a given mode are selected by
rounding to the nearest available filter width per memory.

Fixes #10929

@kk7ds
Copy link
Owner Author

kk7ds commented Nov 5, 2023

cc @WCurlew and @Old-Phart ... This is my proposed fix for bug 10929, let me know what you think. It'd be nice if at least one of you can test this too, of course. Bill, I will hold off on merging this until we get your PR #803 done and then I'll fix the conflicts.

@WCurlew
Copy link
Contributor

WCurlew commented Nov 6, 2023

I did give this a quick run through with the FT450D image and it seemed OK, can't test FT450 as PY not updated for that, but don't see why it wouldn't work, common code.

@kk7ds kk7ds force-pushed the bug/10929/ft450filter branch from b510d36 to fd6c52a Compare November 6, 2023 23:14
@kk7ds
Copy link
Owner Author

kk7ds commented Nov 6, 2023

This has the ft450 changes in it for testing, but will have them rebased out when that merges (first).

kk7ds added 2 commits November 7, 2023 15:22
This driver exposed a different setting for each memory in extra
depending on the mode of that memory. That's not compatible with the
UI's exploding of extra fields into columns, and in general breaks
the ability to edit a whole memory in the properties dialog.

This makes it expose one setting with all the available options, but
ensures that only filters valid for a given mode are selected by
rounding to the nearest available filter width per memory.

Fixes #10929
@kk7ds kk7ds force-pushed the bug/10929/ft450filter branch from fd6c52a to ca32876 Compare November 7, 2023 23:22
@kk7ds kk7ds merged commit 203d739 into master Nov 7, 2023
6 checks passed
@kk7ds kk7ds deleted the bug/10929/ft450filter branch November 7, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants