Bitwise strict checks and byte-compat deprecations #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Nov 6, 2023
kk7ds
commented
- Add a way to test for compat bytes usage
- Default bitwise's get_raw() to byte-native
- Fix deprecated trunc instead of int
- Add warnings for non-byte-clean raw methods
- Add test for strict bitwise seeks
kk7ds
force-pushed
the
bitwise-cleanups
branch
2 times, most recently
from
51021d4 to
c5eef46
Compare
A lot of radios are still relying on get_raw() returning a str instead of a bytes. This adds an environment flag that can be used to run without that compatibility layer to smoke out those offending drivers.
This makes get_raw() byte-native and requires opting into the old compatibility behavior of returning a string. All new code should be using byte-native results from this, which this will help. All existing drivers not asking for asbytes=True have been changed to request asbytes=False. I used diff-cover to manually examine any lines not covered by tests to ensure they were compliant, so this should not introduce any new behavior.
This makes us log a warning when a driver uses a get_raw(asbytes=False) or set_raw() with a str argument instead of bytes. Those need to get fixed up and this will help us notice when a driver is not converted.
This shows which drivers use negative and unnecessary seeks. These are all marked as XFAIL right now because there are *so* many offenders.
This driver has some very non-chirp-conventional black-like formatting, which after fixing, saves about 200 vertical lines. Grr. Also take this opportunity to modernize the driver, remove the future check, fix to be fully byte-clean.
kk7ds
force-pushed
the
bitwise-cleanups
branch
from
c5eef46 to
4201544
Compare
|
Unit failure is because repeaterbook is down right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.