Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inotify using File::Tail::Inotify2 #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbraz
Copy link

@sbraz sbraz commented Dec 16, 2014

Hi, I quickly hacked up mlog2waffle to make it support inotify. In my opinion, this should even enabled by default default when possible.
It is missing the FULL_TAIL logic, maybe you could make it work as well or maybe it should mentioned in the config.
Let me know if this pull request looks OK.

@klaubert
Copy link
Owner

sbraz,

Have you used mlog2waffle with your inotify patch? It have improved in some way the performance?

Best regards.

Klaubert

@sbraz
Copy link
Author

sbraz commented Aug 26, 2015

Hi, I do not really have a way of checking whether the performance is better as I never really used the polling method.
I found out however that my mlog2waffle tends to use huge amounts of memory when it runs for a few days so I restart it daily. I do not know if that is related to inotify or not.

@klaubert
Copy link
Owner

Thank you for the update, I will check how to integrate with full tail.

Best regards,
Klaubert
Em 26/08/2015 7:51 AM, "Louis Sautier" notifications@github.com escreveu:

Hi, I do not really have a way of checking whether the performance is
better as I never really used the polling method.
I found out however that my mlog2waffle tends to use huge amounts of
memory when it runs for a few days so I restart it daily. I do not know if
that is related to inotify or not.


Reply to this email directly or view it on GitHub
#29 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants