feat: track tx hashes, parse evidence, fix appeal bugs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge, still more commits in scope |
jaybuidl
previously approved these changes
Oct 18, 2023
greenlucid
dismissed
jaybuidl’s stale review
The merge-base changed after approval.
Ended up becoming a large scope PR: - tracking and parsing evidence - change evidencegroup logic to ensure removal requests have their evidence included (since they emit Evidence 1st) - fix handleRuling bug PR will continue being larger in scope, next fix is changing the newRound logic so that the newRound is appended upon AppealDecision, not Contribution might be related to the appeal bug
jaybuidl
force-pushed
the
feat/track-tx-hashes
branch
from
df575c8 to
e587c5f
Compare
|
SonarCloud Quality Gate failed.
|
jaybuidl
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.