Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Correctly display initial value #328

Closed
wants to merge 2 commits into from
Closed

fix(search): Correctly display initial value #328

wants to merge 2 commits into from

Conversation

Trishu-Patel
Copy link
Contributor

No description provided.

@Trishu-Patel Trishu-Patel added the bug Something isn't working label Jan 6, 2025
@Trishu-Patel Trishu-Patel force-pushed the trishu-search-value-fix branch from 62e143b to 1e30359 Compare January 6, 2025 19:51
@Trishu-Patel Trishu-Patel force-pushed the trishu-search-value-fix branch from 1e30359 to c6a1b8b Compare January 6, 2025 19:52
TSenter
TSenter requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@TSenter TSenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the purpose behind these changes? By computing searchString only once in the constructor, any other changes to this.value (without typing into the field and overwriting it) won't be reflected here.

@Trishu-Patel Trishu-Patel deleted the trishu-search-value-fix branch January 14, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TSenter TSenter TSenter requested changes

@KeithClinard KeithClinard Awaiting requested review from KeithClinard

@lnicely lnicely Awaiting requested review from lnicely

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trishu-Patel @TSenter