[plugin-klogs] feat: adds button to remove column from Documents table #608
+96
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 72.24% 72.26% +0.02%
==========================================
Files 430 430
Lines 66635 66645 +10
Branches 2879 2891 +12
==========================================
+ Hits 48141 48163 +22
+ Misses 18194 18180 -14
- Partials 300 302 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
About the styling of the button, I am not fully sure. As you can see, the overall styling of Kobs/Klogs is not right, but thats b/c of my hacked local setup (see #607). Here a short demo: Bildschirmaufnahme.2023-12-21.um.14.52.13.mov |
matthiastz
commented
Dec 21, 2023
matthiastz
commented
Dec 21, 2023
Comment on lines
+527
to
+536
| <IconButton | ||
| edge="end" | ||
| color="inherit" | ||
| size={'small'} | ||
| sx={{ m: 0 }} | ||
| aria-label="toggle field column" | ||
| onClick={() => selectField?.(field)} | ||
| > | ||
| <TableChart sx={{ fontSize: 16 }} /> | ||
| </IconButton> |
|
for consistency i used the TableChart icon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a button remove columns directly from the Documents table header. This eases the work quite a lot, for example:
when you have 3+ "custom" (not Time or Log) columns open, you do not need to scroll through all of the properties of a "log line" (Document)
when you aggregate logs where certain properties are not set (or you aggregate them from different services etc.), removing the column as it is from the Document table header is quite convenient ;)
I adjusted the corresponding documentation for this change.
I adjusted the values.yaml and the documentation for all values.