Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnhanceStatus not properly called for GET calls to /api/k8s/{kind}/get #516

Closed
alessandrodetta opened this issue Feb 27, 2024 · 1 comment · Fixed by #517
Closed

EnhanceStatus not properly called for GET calls to /api/k8s/{kind}/get #516

alessandrodetta opened this issue Feb 27, 2024 · 1 comment · Fixed by #517

Comments

@alessandrodetta
Copy link
Contributor

alessandrodetta commented Feb 27, 2024 •
edited
Loading

Description

While looking into code for solution of #418, I think I found a bug where the status of resource kind is not "enhanced" because of a little pointer bug.
I suppose the status in result object should hold the same values as for GET calls to /api/helm/releases/{ns}/{name}/resources with query parameter health set to true. If that is the case, I'm going to submit a fix for it.

Screenshots

No response

Additional information

No response
@undera
Copy link
Collaborator

undera commented Feb 28, 2024

Sorry, I could not understand clearly your proposition. Can you demonstrate it with PR, if it's not too much of work?
Thank you

@alessandrodetta alessandrodetta mentioned this issue Feb 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@undera @alessandrodetta