Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource status not enhanced for calls to /api/k8s/{kind}/get route #517

Merged

Conversation

alessandrodetta
Copy link
Contributor

@alessandrodetta alessandrodetta commented Feb 28, 2024

Changes Proposed

The pointer address returned from EnhanceStatus is now correctly set, following the same structure adopted in Resources function of /pkg/dashboard/handlers/helmHandlers.go

Check List

@undera
Copy link
Collaborator

undera commented Feb 28, 2024

After looking a bit into it, I don't see this code called at all. Did you find the use action when it's called?

@alessandrodetta
Copy link
Contributor Author

@undera I just limited my search to backend while testing the REST API for understanding purposes.

Now that I look into frontend, I don't find any usage either. I don't know if it makes sense then to apply a fix to something that is still not in a final state or will be removed... I assumed that the endpoint was used because it existed. In any case, if you want to keep the call to EnhanceStatus inside the function, that piece of code will have to be fixed.

@undera
Copy link
Collaborator

undera commented Feb 28, 2024

Let's have it fixed anyway. Probably the endpoint should be marked as deprecated.

@undera undera merged commit aac7e7d into komodorio:main Feb 28, 2024
3 of 4 checks passed
@undera
Copy link
Collaborator

undera commented Feb 28, 2024

Thank you for reporting this inconsistency!

@alessandrodetta
Copy link
Contributor Author

Let's have it fixed anyway. Probably the endpoint should be marked as deprecated.

Thank you for reporting this inconsistency!

The pleasure is mine! Rather excuse me, I still have a lot to learn in order to contribute better in the project and on github in general 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnhanceStatus not properly called for GET calls to /api/k8s/{kind}/get
2 participants