Skip to content

Commit

Permalink
Remove tooling image parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
rnc committed Jan 17, 2025
1 parent d024b98 commit 714344c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
3 changes: 1 addition & 2 deletions task/pnc-prebuild-git-clone-oci-ta/0.1/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# pnc-prebuild-git-clone-oci-ta task

The pnc-prebuild-git-clone-oci-ta Task will clone a repo from the provided url, apply PNC prebuild modifications and store it as a trusted artifact in the provided OCI repository.
The pnc-prebuild-git-clone-oci-ta Task will clone a repo from the provided url, apply PNC prebuild modifications from https://github.com/project-ncl/konflux-tooling and store it as a trusted artifact in the provided OCI repository.

## Parameters
|name|description|default value|required|
Expand Down Expand Up @@ -28,7 +28,6 @@ The pnc-prebuild-git-clone-oci-ta Task will clone a repo from the provided url,
|BUILD_TOOL|The build tool to use (ant, gradle, maven, sbt).||true|
|BUILD_TOOL_VERSION|The build tool version to use (e.g. 3.9.5)||true|
|JAVA_VERSION|Java version to use (7, 8, 9, 11, 17, 21, 22, 23)||true|
|PNC_KONFLUX_TOOLING_IMAGE|Name of the tooling image.||true|
|RECIPE_IMAGE|The image from the build recipe to use||true|

## Results
Expand Down
13 changes: 4 additions & 9 deletions task/pnc-prebuild-git-clone-oci-ta/0.1/patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
- op: replace
path: /spec/description
value: The pnc-prebuild-git-clone-oci-ta Task will clone a repo from the provided url, apply
PNC prebuild modifications and store it as a trusted artifact in the provided OCI repository.
PNC prebuild modifications from https://github.com/project-ncl/konflux-tooling and store
it as a trusted artifact in the provided OCI repository.

- op: add
path: /spec/params/-
Expand All @@ -33,12 +34,6 @@
name: JAVA_VERSION
description: Java version to use (7, 8, 9, 11, 17, 21, 22, 23)
type: string
- op: add
path: /spec/params/-
value:
name: PNC_KONFLUX_TOOLING_IMAGE
description: Name of the tooling image.
type: string
- op: add
path: /spec/params/-
value:
Expand All @@ -50,7 +45,7 @@
path: /spec/steps/2
value:
name: preprocessor
image: $(params.PNC_KONFLUX_TOOLING_IMAGE)
image: quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest
securityContext:
runAsUser: 0
computeResources:
Expand All @@ -65,7 +60,7 @@
- --build-tool-version=$(params.BUILD_TOOL_VERSION)
- --java-version=$(params.JAVA_VERSION)
- --recipe-image=$(params.RECIPE_IMAGE)
- --tooling-image=$(params.PNC_KONFLUX_TOOLING_IMAGE)
- --tooling-image=quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest
- --type=$(params.BUILD_TOOL)
- /var/workdir/source
volumeMounts:
Expand Down

0 comments on commit 714344c

Please sign in to comment.