Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Untar to create parent dirs when necessary #1093

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Mar 25, 2024

Since build-tasks-dockerfiles 5805b6, only files are recorded in the headers of generated tar archive. Then, during Untar, the parent directories have to be created firstly.

Issue ticket number and link

konflux-ci/build-definitions#855

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This change does not break anything. After merge, e2e tests should work for konflux-ci/build-definitions#855 by untaring the source archive.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Mar 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tkdchen tkdchen changed the title fix: Fix Untar to create parent dirs if when necessary fix: Fix Untar to create parent dirs when necessary Mar 25, 2024
pkg/utils/util.go Fixed Show fixed Hide fixed
@tkdchen tkdchen force-pushed the fix-Untar branch 2 times, most recently from b9d33b6 to 951ba9d Compare March 25, 2024 07:16
@tkdchen tkdchen marked this pull request as ready for review March 25, 2024 07:22
@openshift-ci openshift-ci bot requested review from pmacik and psturc March 25, 2024 07:22
@tkdchen tkdchen requested review from tisutisu, mmorhun, rcerven, mkosiarc and chmeliik and removed request for pmacik and psturc March 25, 2024 07:22
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tkdchen
Copy link
Contributor Author

tkdchen commented Mar 25, 2024

/retest

@tkdchen tkdchen requested a review from psturc March 25, 2024 13:40
@jinqi7
Copy link
Contributor

jinqi7 commented Mar 28, 2024

/approve

@tkdchen
Copy link
Contributor Author

tkdchen commented Mar 28, 2024

/retest

@dheerajodha
Copy link
Member

Hi @tkdchen, please rebase your branch to get the PRs that fixed and skipped (some of) the tests that failed in your latest CI run.

Since build-tasks-dockerfiles 5805b6, only files are recorded in the
headers of generated tar archive. Then, during Untar, the parent
directories have to be created firstly.

Signed-off-by: Chenxiong Qi <cqi@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Apr 2, 2024
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tkdchen
Copy link
Contributor Author

tkdchen commented Apr 2, 2024

@dheerajodha Hi, rebased. PTAL.

@kasemAlem
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmeliik, jinqi7, kasemAlem, mkosiarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 291c661 into konflux-ci:main Apr 2, 2024
14 checks passed
@tkdchen tkdchen deleted the fix-Untar branch April 2, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants