-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Untar to create parent dirs when necessary #1093
Conversation
Skipping CI for Draft Pull Request. |
b9d33b6
to
951ba9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/approve |
/retest |
Hi @tkdchen, please rebase your branch to get the PRs that fixed and skipped (some of) the tests that failed in your latest CI run. |
Since build-tasks-dockerfiles 5805b6, only files are recorded in the headers of generated tar archive. Then, during Untar, the parent directories have to be created firstly. Signed-off-by: Chenxiong Qi <cqi@redhat.com>
Quality Gate passedIssues Measures |
@dheerajodha Hi, rebased. PTAL. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmeliik, jinqi7, kasemAlem, mkosiarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since build-tasks-dockerfiles 5805b6, only files are recorded in the headers of generated tar archive. Then, during Untar, the parent directories have to be created firstly.
Issue ticket number and link
konflux-ci/build-definitions#855
Type of change
How Has This Been Tested?
This change does not break anything. After merge, e2e tests should work for konflux-ci/build-definitions#855 by untaring the source archive.
Checklist: