-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: test EC only for a single component #1095
fix: test EC only for a single component #1095
Conversation
Tip: hide whitespace changes while reviewing |
4a634e0
to
c02dad9
Compare
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Due to https://issues.redhat.com/browse/KFLUXBUGS-24, testing the EC pipelines takes extremely long (the tests have to wait for the attestation to exist before they can start the EC pipelines). Run the test only for one component to try and improve the situation. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
9ade23c
to
8f69b7b
Compare
Quality Gate passedIssues Measures |
There was a potential nil dereference in the AfterAll, fixed now |
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Tested in konflux-ci/build-definitions#901, where it seems to achieve what's needed Failing here, don't know why /retest |
🚨 Error occurred while running the E2E tests, list of failed Spec(s):
@chmeliik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkosiarc, mmorhun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Dropping, the Chains performance is not tragic anymore so this shouldn't be needed |
Due to https://issues.redhat.com/browse/KFLUXBUGS-24, testing the EC pipelines takes extremely long (the tests have to wait for the attestation to exist before they can start the EC pipelines).
Run the test only for one component to try and improve the situation.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: