Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test EC only for a single component #1095

Conversation

chmeliik
Copy link
Contributor

Due to https://issues.redhat.com/browse/KFLUXBUGS-24, testing the EC pipelines takes extremely long (the tests have to wait for the attestation to exist before they can start the EC pipelines).

Run the test only for one component to try and improve the situation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@chmeliik
Copy link
Contributor Author

Tip: hide whitespace changes while reviewing

@chmeliik chmeliik force-pushed the temp-skip-ec-pipelines-for-build-tests branch from 4a634e0 to c02dad9 Compare March 25, 2024 11:24
@chmeliik chmeliik changed the title build tests: test EC only for a single component fix: test EC only for a single component Mar 25, 2024
chmeliik added a commit to chmeliik/build-definitions that referenced this pull request Mar 25, 2024
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik added a commit to chmeliik/build-definitions that referenced this pull request Mar 25, 2024
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Due to https://issues.redhat.com/browse/KFLUXBUGS-24, testing the EC
pipelines takes extremely long (the tests have to wait for the
attestation to exist before they can start the EC pipelines).

Run the test only for one component to try and improve the situation.

Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
@chmeliik chmeliik force-pushed the temp-skip-ec-pipelines-for-build-tests branch from 9ade23c to 8f69b7b Compare March 26, 2024 12:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@chmeliik
Copy link
Contributor Author

There was a potential nil dereference in the AfterAll, fixed now

chmeliik added a commit to chmeliik/build-definitions that referenced this pull request Mar 26, 2024
Signed-off-by: Adam Cmiel <acmiel@redhat.com>
@chmeliik
Copy link
Contributor Author

Tested in konflux-ci/build-definitions#901, where it seems to achieve what's needed

Failing here, don't know why

/retest

Copy link

openshift-ci bot commented Mar 26, 2024

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

  • ➡️ [failed] [It] [integration-service-suite Status Reporting of Integration tests] with status reporting of Integration tests in CheckRuns when a new Component with specified custom branch is created eventually leads to the build PipelineRun's status reported at Checks tab [integration-service, HACBS, status-reporting, custom-branch]
the PR 5144 in hacbs-test-project-integration repo doesn't contain the expected conclusion (success) of the CheckRun
Expected
    <string>: failure
to equal
    <string>: success
  • ➡️ [failed] [It] [multi-platform-build-service-suite Multi Platform Controller E2E tests] ibm system z dynamic allocation when the Component with multi-platform-build is created The multi platform secret is populated [multi-platform, ibmz-dynamic]
Timed out after 1200.001s.
timed out when verifying the secret is created
Expected success, but got an error:
    <*errors.StatusError | 0xc00159cc80>: 
    secrets "multi-platform-ssh-multi-platform-suite-component-mnwp-hmkbw-build-container" not found
    {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "secrets \"multi-platform-ssh-multi-platform-suite-component-mnwp-hmkbw-build-container\" not found",
            Reason: "NotFound",
            Details: {
                Name: "multi-platform-ssh-multi-platform-suite-component-mnwp-hmkbw-build-container",
                Group: "",
                Kind: "secrets",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 0,
            },
            Code: 404,
        },
    }

@chmeliik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e 8f69b7b link true /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkosiarc, mmorhun
Once this PR has been reviewed and has the lgtm label, please assign tisutisu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chmeliik
Copy link
Contributor Author

Dropping, the Chains performance is not tragic anymore so this shouldn't be needed

@chmeliik chmeliik closed this Mar 28, 2024
@chmeliik chmeliik deleted the temp-skip-ec-pipelines-for-build-tests branch March 28, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants